Closed luccacabra closed 6 years ago
Thanks for the contribution. Bug me if I don't review for merge within a few days. Hoping to review it today or tomorrow.
Looks good. Some additional test coverage for this would be great, but it dovetails with some testing I'm planning to do. Going to merge as-is.
I can't find this exactly in documentation as Trello doesn't document expected API responses (🤦♂️ ), but when calling the search endpoint locally and via this repo, I'm getting
JSON
errors:and upon further inspection of the data returned by that endpoint:
it appears that the
modifiers
data type is indeed no longer an array ofstring
s, but an array ofmap[string][string]
s. I've updated theSearchOptions.modifiers
type to reflect that change.