Support for adding URL Attachments to a card

adlio / trello

Trello API wrapper for Go

MIT License

220 stars 71 forks source link

Support for adding URL Attachments to a card #27

Closed mauromsl closed 5 years ago

mauromsl commented 5 years ago

I find your library really useful, but seems to lack API calls to add attachments onto cards.

This PR covers my use case, which is to link Trello cards with GitHub issues via the GitHub Power-up: https://trello.com/power-ups/55a5d916446f517774210004/github

coveralls commented 5 years ago

Coverage decreased (-11.05%) to 71.614% when pulling 1bccb502b8e69a540054088d680699a26e00958d on mauromsl:master into e4cc07c871d0ee17c5579131fc1c786efbb5fe2a on adlio:master.

adlio commented 5 years ago

Excellent. Thanks for the contribution. Would you mind adding a test? I'm less focused on the test coverage number and more on being able to use the JSON in the tests to test and debug edge cases.

adlio commented 5 years ago

Fat-fingered the close button. Oops.

mauromsl commented 5 years ago

Okay, test case added. Let me know what you think

adlio commented 5 years ago

Thanks for the contribution. Merging. I'll be fixing the Travis/Coveralls stuff today.