adlio / trello

Trello API wrapper for Go
MIT License
220 stars 71 forks source link

feat(label): add create label function #29

Closed ullayne02 closed 3 years ago

ullayne02 commented 5 years ago

Adiciona o método para criar uma label no board

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-11.6%) to 71.101% when pulling a51ee7a47ba2ba44ff4079c9ad50e8c10f83bfee on inloco:create-label into e4cc07c871d0ee17c5579131fc1c786efbb5fe2a on adlio:master.

adlio commented 5 years ago

HI @ullayne02, thanks for the PR. The code looks right to me, but I haven't had a chance to test it yet.

Would you be willing to add a test case to cover the new code? I'm looking to the test coverage to help aid in debugging future changes to JSON structure Trello might make on their side.

ullayne02 commented 5 years ago

HI @ullayne02, thanks for the PR. The code looks right to me, but I haven't had a chance to test it yet.

Would you be willing to add a test case to cover the new code? I'm looking to the test coverage to help aid in debugging future changes to JSON structure Trello might make on their side.

Sure!! I'll upload the PR.

fdcds commented 4 years ago

Is someone still working on this?

adlio commented 3 years ago

Is someone still working on this?

Just merged an updated version with test coverage. Note the method signature changed to:

func (b *Board) CreateLabel(label *Label, extraArgs ...Arguments) error {

... to match similar functions like CreateCard.