search

adlio / trello

Trello API wrapper for Go
MIT License
220 stars 71 forks source link

Create and delete methods for boards #31

Closed jtsaito closed 5 years ago

jtsaito commented 5 years ago

This PR adds methods for creating and deleting boards which have so far been missing.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-9.2%) to 73.465% when pulling 7b44fef3fc5d25d0b58b645b1cae18a5e8c085da on jtsaito:create-board into e4cc07c871d0ee17c5579131fc1c786efbb5fe2a on adlio:master.

jtsaito commented 5 years ago

Travis CI's setup for Go 1.8 is failing: https://travis-ci.org/adlio/trello/builds/494733705?utm_source=github_status&utm_medium=notification. This appears to be a problem with Travis CI.

For the purpose of this PR, I have replaced Go 1.8 support by Go 1.9 support. This seems to work. However, this is not a proper solution to the actual problem that Go 1.8 support seems to be broken.

Moreover, the setup of coverall on Travis CI seems to be broken as well.

adlio commented 5 years ago

@jtsaito Thanks. It looks like I have another project that was formerly passing tests on that version and is no longer... I'm inclined to focus on 1.10/1.11, as I've moved all my work there. Will review this PR today.

jtsaito commented 5 years ago

@adlio Thanks!

Btw., I was considering a few small PRs for making the code base conform to golint and govet (mainly because my vim-plug is complaining about a ton of minor things). The scope would include stuff like commenting public member methods, renaming some variables and then adding golint and govet to Travis CI. Now, before I start diving into this, do you feel this would be helpful or would you rather prefer not to add linting?

adlio commented 5 years ago

That’d be excellent, thanks. I was thinking about doing the same - for the same reasons.

On Mon, Feb 18, 2019 at 8:05 AM Jahn Saito notifications@github.com wrote:

@adlio https://github.com/adlio Thanks!

Btw., I was considering a few small PRs for making the code base conform to golint and govet (mainly because my vim-plug is complaining about a ton of minor things). The scope would include stuff like commenting public member methods, renaming some variables and then adding golint and govet to Travis CI. Now, before I start diving into this, do you feel this would be helpful or would you rather prefer not to add linting?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/adlio/trello/pull/31#issuecomment-464765600, or mute the thread https://github.com/notifications/unsubscribe-auth/AABrZOO61ZyQ3VeTKwC3MrAqU92tmmgHks5vOsFLgaJpZM4bAK_X .