search

adlio / trello

Trello API wrapper for Go
MIT License
220 stars 71 forks source link

Golint 2 #33

Closed jtsaito closed 5 years ago

jtsaito commented 5 years ago

This PR replaces https://github.com/adlio/trello/pull/32.

This PR makes the repo pass golint and adds linting to the Travis config.

Comments have been added or their style fixed. A few variables have been renamed.

codecov-io commented 5 years ago

Codecov Report

Merging #33 into master will increase coverage by 0.09%. The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   71.84%   71.93%   +0.09%     
==========================================
  Files          19       19              
  Lines         760      759       -1     
==========================================
  Hits          546      546              
+ Misses        180      179       -1     
  Partials       34       34
Impacted Files Coverage Δ
search.go 100% <ø> (ø) :arrow_up:
list-duration.go 83.33% <ø> (ø) :arrow_up:
arguments.go 100% <ø> (ø) :arrow_up:
label.go 100% <ø> (ø) :arrow_up:
webhook.go 41.46% <ø> (ø) :arrow_up:
list.go 100% <ø> (ø) :arrow_up:
member.go 100% <ø> (ø) :arrow_up:
list-duration-sort.go 100% <ø> (ø) :arrow_up:
token.go 100% <ø> (ø) :arrow_up:
action.go 94.91% <ø> (ø) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d090822...62480ab. Read the comment docs.

jtsaito commented 5 years ago

golint is no longer go-gettable for old go versions (1.7, 1.8). I added a workaround that ignores linting for these versions but lints for other versions of go.

jtsaito commented 5 years ago

@adlio You are right, I'm sorry I forgot to highlight the changed attribute names. Thanks for taking time to review and merge this!