xescugc commented 5 years ago

I needed to work with the Trello notifications and I've found that those where missing from this lib so I just added a basic implementation of the GetMyNotifications.

On my tests those are data that I could find that it returned, it could potentially need more data in side the Data field but I could not find it and it's not on the trello documentation.

To do this implementation I basically copied the GetMyBoards implementation and tests as it's basically the same usecase.

On the tests I've removed numbers from the IDs and changes sensible data from them too.

codecov-io commented 5 years ago

Codecov Report

Merging #34 into master will increase coverage by 0.22%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   71.93%   72.15%   +0.22%     
==========================================
  Files          19       20       +1     
  Lines         759      765       +6     
==========================================
+ Hits          546      552       +6     
  Misses        179      179              
  Partials       34       34

Impacted Files	Coverage Δ
notification.go	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b0faddb...30cc47b. Read the comment docs.

adlio commented 5 years ago

Thanks for the contribution @xescugc! Apologies on the long delay to merge... been busy the last month or so.

adlio / trello

Added the implementation of 'GetMyNotifications' #34

Codecov Report