Closed alecthomas closed 4 years ago
There's opportunity for factoring out more common code across these methods, as they are all almost identical, but this more minimal change fixes the bug with Post()
.
Merging #55 into master will increase coverage by
1.15%
. The diff coverage is81.81%
.
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 76.82% 77.98% +1.15%
==========================================
Files 21 21
Lines 850 822 -28
==========================================
- Hits 653 641 -12
+ Misses 159 151 -8
+ Partials 38 30 -8
Impacted Files | Coverage Δ | |
---|---|---|
client.go | 82.41% <81.81%> (+9.3%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0f19bd4...a5c95e5. Read the comment docs.
@alecthomas Thank you for the refactoring and bugfix.
Factor out common code so response handling is consistent.