search

adlio / trello

Trello API wrapper for Go
MIT License
219 stars 71 forks source link

Add functions to archive & unarchive a card #66

Closed utkuufuk closed 4 years ago

utkuufuk commented 4 years ago

This PR adds shorthands for archiving and unarchiving a card.

Even though both actions can be done using the existing Update method, having explicit methods for these actions would increase the ease of use IMHO.

Also, it was one of the items in TODO.txt

codecov-commenter commented 4 years ago

Codecov Report

Merging #66 into master will decrease coverage by 0.32%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   73.25%   72.93%   -0.33%     
==========================================
  Files          21       21              
  Lines         890      894       +4     
==========================================
  Hits          652      652              
- Misses        206      210       +4     
  Partials       32       32
Impacted Files Coverage Δ
card.go 56.52% <0.00%> (-1.01%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc8f627...1de8012. Read the comment docs.

utkuufuk commented 4 years ago

@adlio I added the tests after opening the PR, but the coverage report didn't get triggered the second time. Is there a way to manually trigger it or should I close and re-open the PR?

adlio commented 4 years ago

Thanks for the contribution! Tests look good. FYI it's going to take me a bit to make a new release with this, but it'll be in master,