search

adlio / trello

Trello API wrapper for Go
MIT License
219 stars 71 forks source link

Fix #74 - make extra arguments optional #78

Closed TJM closed 3 years ago

TJM commented 3 years ago

There were two different patterns..

One where the object was passed in and a bunch of "args" were created based on specific fields (probably not very extensible), then sometimes (or not) a couple extraArgs were applied. In this case, I tried to make the initial "args" creation more consistent, and allow them to be overridden with "extraArgs" ... I also made it so that any argument can be overridden, rather than the one or two options that were in the code.

The other pattern was just to pass the extra args directly to the "client" command... those were easy.

To make it all better, now we no longer need the "trello.Defaults()" on every single command. YAY!?

~tommy

TJM commented 3 years ago

Guess the README needs some serious updating :)