search

adlnet-archive / 3D-Repository

The ADL 3D Repository is a website for uploading, finding, and downloading 3D models.
25 stars 16 forks source link

Input validation #15

Open rchadwic opened 12 years ago

rchadwic commented 12 years ago

So, I've been working with a user, and it looks like we really need much more input validation all over the place. Specifically, we should check the database and check the max length of all the strings. Then add validation to prevent inputs that are too long. This poor guy was getting odbc data too long errors all over the place. Also let's put 'placeholder' attributes on blank fields. Also, make sure users know that the keywords are comma separated.

rchadwic commented 12 years ago

Actually, having been over the site, there were only a few places that needed validation. I did add some max length properties, and client side formatting for the keywords. Maybe this is not that big an issue. I'm not sure how that user was able to get so many max length issues.

mickmuzac commented 12 years ago

That sounds extremely strange. Does the user have any actual test cases that we can replicate to see the problem (might not matter now since you added fixes)?

Do you think it would make sense to use TEXT data types instead of VARCHAR/CHAR types in more places to avoid string length issues? I'll add a small note letting users know that commas are used as the delimiter for searching.

rchadwic commented 12 years ago

Perhaps only text in the description. I read up on it over the weekend, and it seems like that would slow the searches. The database is slow already, so I don't want to make it worse. I was able to replicate and correct some of the user issues, but not the one related to keywords.

mickmuzac commented 12 years ago

I can definitely work on it over the next couple of days. What exactly is the problem?

rchadwic commented 12 years ago

you know, I'm no longer sure. Maybe we just call this a "cannot replicate"