search

adlnet / Moodle-mod_cmi5launch

A Moodle plugin which allows teachers to upload cmi5 packaged lessons within a Moodle Course Activity and then assign the activity to students
Apache License 2.0
5 stars 4 forks source link

function naming violations #31

Closed danmarsden closed 6 months ago

danmarsden commented 6 months ago

Many of the functions at the end of: https://github.com/adlnet/cmi5-player-moodle-plugin/blob/main/lib.php and possibly all functions defined in locallib.php violate the function naming guidelines - please see: https://moodledev.io/general/development/policies/codingstyle/frankenstyle#function-names

note this is a blocker for plugins db approval.

ADLMeganBohland commented 6 months ago

@danmarsden Hi, so instead of starting cmin5launch_ it should be mod_cmi5launch?

danmarsden commented 6 months ago

activity plugins are allowed to skip the "mod_" part of the frankenstyle naming but functions like this: function use_global_cmi5_lrs_settings(

are not allowed.

so either of these would be allowed and follow the guidelines: function mod_cmi5launch_lrs_settings() function cmi5launch_lrs_settings()

ADLMeganBohland commented 6 months ago

@danmarsden All the incorrect functions have been renamed. Thank you!