search

adlnet / Moodle-mod_cmi5launch

A Moodle plugin which allows teachers to upload cmi5 packaged lessons within a Moodle Course Activity and then assign the activity to students
Apache License 2.0
5 stars 5 forks source link

constant naming violations #32

Closed danmarsden closed 8 months ago

danmarsden commented 8 months ago

These are incorrect: https://github.com/adlnet/cmi5-player-moodle-plugin/blob/main/locallib.php#L518-L534

Please see: https://moodledev.io/general/development/policies/codingstyle/frankenstyle#constants

note this is a blocker for plugins db approval.

ADLMeganBohland commented 8 months ago

@danmarsden Thank you for the input, I have adjusted constants accordingly!