adlnet / lrs-conformance-test-suite

A NodeJS project that tests the MUST requirements of the xAPI Spec and is based on the ADL testing requirements repository. The test suite website can be found here: https://lrstest.adlnet.gov/. The adopters website can be found here: https://adopters.adlnet.gov/
https://adlnet.gov/projects/xapi/
MIT License
67 stars 42 forks source link

more thorough testing of agent parameter on GET Statements requests #218

Open cr8onski opened 7 years ago

cr8onski commented 7 years ago

The current tests in the test suite retrieve statements from an LRS using the agent parameter and a specific agent, then test that the requested agent is contained in the retrieved statements.

The above testing still leaves a hole where an LRS could pass that test, however not be able to meet a case where a just a specific IFI is used to query an LRS.

According to my reading of the specification, an LRS should return any statement with an actor or object which has an agent or group which contains that IFI, regardless of other agent or group information. Communication 2.1.3 Table row 3

If this is right, I propose the new tests to cover this gap. Also would this need an additional requirement?