search

adlnet / lrs-conformance-test-suite

A NodeJS project that tests the MUST requirements of the xAPI Spec and is based on the ADL testing requirements repository. The test suite website can be found here: https://lrstest.adlnet.gov/. The adopters website can be found here: https://adopters.adlnet.gov/
https://adlnet.gov/projects/xapi/
MIT License
67 stars 42 forks source link

Console runner should provide non-zero exit code for failures #221

Closed ryasmi closed 6 years ago

ryasmi commented 7 years ago

Version Master branch at commit 3a04557d73173e50ae55fb37a5aa4e68fad924d2

Steps to reproduce the issue

  1. Run the tests with invalid auth details.

Expected behaviour The runner should exit with a non-zero exit code so that CI tools show a failed build.

Actual behaviour The runner exits with a zero exit code.

vbhayden commented 6 years ago

Did the merge add the functionality requested with this issue?

ryasmi commented 6 years ago

No the PR that was merged into LearningLocker's xAPI service didn't fix the issue here.

ryasmi commented 6 years ago

The open PR should fix the issue.