search

adlnet / xAPI-Spec

The xAPI Specification describes communication about learner activity and experiences between technologies.
https://adlnet.gov/projects/xapi/
907 stars 404 forks source link

Correct rendering in 2.5.s2 table #1046

Closed adamnbowen closed 7 years ago

adamnbowen commented 7 years ago

This removes an extra blank line that caused a bug in the rendering of the table on GitHub.

garemoko commented 7 years ago

@adamnbowen thanks for this. I think this PR needs to go to the master branch. @andyjohnson do you agree?

adamnbowen commented 7 years ago

@garemoko ah, wasn't sure, since the contributor's guidelines point to the "Development" branch, which was a link to 1.0.3

adamnbowen commented 7 years ago

@garemoko I've updated the PR to point to master instead.

garemoko commented 7 years ago

@adamnbowen you rebased but the PR is still targeting master. I'm not sure you can change that; I think you have to create a new PR (from the same branch).

adamnbowen commented 7 years ago

@garemoko does it not show "adamnbowen wants to merge 1 commit into adlnet:master from adamnbowen:patch-1" along the top of the page for you? I change the base branch of PRs for work often, and it changes where the PR is merged into (but is not the same as rebasing, if I recall correctly).

garemoko commented 7 years ago

@adamnbowen apologies - yes this is right. @andyjohnson we should merge this.