adlnet / xAPI-Spec

The xAPI Specification describes communication about learner activity and experiences between technologies.
https://adlnet.gov/projects/xapi/
899 stars 405 forks source link

A possible discrepancy in PUT Statements doc #1104

Open raouldj opened 2 years ago

raouldj commented 2 years ago

In https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Communication.md#stmtres "2.1.1 PUT Statements" under the "Details" it is said that the PUT endpoint "Stores a single Statement with the given id." However the last item in the "LRS Requirements" states following: "If the LRS receives a batch of Statements containing two or more Statements with the same id, it SHOULD* reject the batch and return 400 Bad Request.".

This seems to be a copy paste error from "2.1.2 POST Statements" since the PUT statements endpoint should not be able to handle batches of statements as stated under the "Details".

thomasturrell commented 1 year ago

@andyjohnson what is the process for pull requests for the xAPI spec?

I believe that this is a legitimate issue.

andyjohnson commented 1 year ago

Thanks for your keen eyes, everyone. We did catch this as we transition to the IEEE and effectively xAPI 2.0. This process has taken much longer than anticipated, but it will be an open standard and shared from this GitHub once publicly available.

erickr commented 1 year ago

@andyjohnson Is there any publicly available summary of what the scope of changes are for the xAPI 2.0 on a technical level?

andyjohnson commented 1 year ago

Hey Eric, check out the report here: https://adlnet.gov/publications/2021/07/adl-xapi-rmf-accreditation-project-final-report/

Thanks!

Andy

From: Eric Krona @.> Sent: Friday, August 19, 2022 4:04 AM To: adlnet/xAPI-Spec @.> Cc: Andy Johnson @.>; Mention @.> Subject: Re: [adlnet/xAPI-Spec] A possible discrepancy in PUT Statements doc (Issue #1104)

@andyjohnsonhttps://github.com/andyjohnson Is there any publicly available summary of what the scope of changes are for the xAPI 2.0 on a technical level?

— Reply to this email directly, view it on GitHubhttps://github.com/adlnet/xAPI-Spec/issues/1104#issuecomment-1220374674, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAKDP25IGO4YXXMMO7KJ7KTVZ45XVANCNFSM5Z5OPIEA. You are receiving this because you were mentioned.Message ID: @.**@.>>

scherrey commented 11 months ago

Just noticed this issue today when my team was asking me about how to implement PUT with multiple statements. My first reaction was that this doesn't seem to jive with PUT semantics at all so I'm glad I'm not the only one who feels this way. It's been a year since last comment on this item. Have IEEE xAPI 2.x efforts kicked off and, if so, how can one get involved?

brianjmiller commented 11 months ago

1.03 -> 2.0.0 Change Log can be found at https://opensource.ieee.org/xapi/xapi-base-standard-documentation/-/blob/main/ChangeLog.md

xAPI 2.0 is now an IEEE standard. Any continuing work is done through LTSC committee working groups, with the base standard being the important one for the xAPI standard itself: https://sagroups.ieee.org/9274-1-1/