search

adlnet / xAPI-Spec

The xAPI Specification describes communication about learner activity and experiences between technologies.
https://adlnet.gov/projects/xapi/
905 stars 405 forks source link

Update signed statements section to reference current JWS spec #945

Closed stevenvergenz closed 8 years ago

stevenvergenz commented 8 years ago

As of May 2015, JSON Web Signatures have left "draft" status and been officially endorsed as RFC 7515. This PR updates the link to point to the new RFC.

It also changes the contentType of statement signatures from application/octet-stream to application/jose, as required by the RFC (and the older draft, incidentally).

Thoughts?

brianjmiller commented 8 years ago

The MIME type change is a major version breaking change. application/octet-stream will work for anything that is application/jose and the combination of the usageType + contentType notifies systems how it should be consumed.

brianjmiller commented 8 years ago

Note the RFC is indicating that the content type has been registered for this purpose, but there is no "requirement" to use it in any particular situation.

fugu13 commented 8 years ago

Yeah, this is a change for a future version of the spec. Even if we decide it is acceptable to also allow it as an option in a future 1.0.x (no idea if we will), it definitely shouldn't go into 1.0.3, which is about the restructure and clarity.

brianjmiller commented 8 years ago

Without reviewing the rest of the RFC for breaking changes from the draft I'm not sure we can confidently switch to pointing to the RFC.

stevenvergenz commented 8 years ago

That's a good point. I'm not necessarily advocating that we switch, but I wanted to get the group's thoughts after I discovered that mime type thing. Octet works fine, it'll keep.

stevenvergenz commented 8 years ago

Closing for now, we can revisit this topic for 1.1.