search

adlnet / xAPI-Spec

The xAPI Specification describes communication about learner activity and experiences between technologies.
https://adlnet.gov/projects/xapi/
905 stars 405 forks source link

Should the list of statement ids returned have to be in the same order as statements sent? #949

Closed garemoko closed 8 years ago

garemoko commented 8 years ago

For 1.1.

See https://groups.google.com/a/adlnet.gov/forum/#!topic/xapi-spec/tK_GHYgKjAY

DavidTPate commented 8 years ago

I would think this would be a MUST. Let's say that I sent 3 Statements via POST /statements and I don't include any value for statement.id which is valid based on this:

Ids MUST be generated by the LRS if a Statement is received without an id.

Then the only way I would know which statement id goes to which statement (possibly to use it for a StatementRef or Voided statement) would be based upon the order.

garemoko commented 8 years ago

Perhaps this can be a SHOULD* in 1.0.3 actually.

fugu13 commented 8 years ago

I don't think there's any reasonable reading of the spec where this isn't already an implied MUST; without it, the returned IDs are nearly useless. I'd also thought this had previously been discussed (with action item to add), though probably on a call so I doubt there's a record, and my recollection isn't strong enough to be confident I'm not conjuring things.

brianjmiller commented 8 years ago

@fugu13 👍 , see #378 and #517.

garemoko commented 8 years ago

PR merged. Closing