search

adlnet / xAPI-Spec

The xAPI Specification describes communication about learner activity and experiences between technologies.
https://adlnet.gov/projects/xapi/
905 stars 405 forks source link

1.3 grammar style on communication #960

Closed andyjohnson closed 8 years ago

andyjohnson commented 8 years ago

I realized I didn't have a new branch when I started editing the first lines and navigated away, figuring it would cancel. That first commit may be that. I simply repeated in the next commit, so hopefully nothing wonky happened in there. Look in each commit for notes. Thanks!

garemoko commented 8 years ago

Added a couple of comments, otherwise looks good.

andyjohnson commented 8 years ago

Thanks for this, Andrew. Going to fix the id(s) - Honestly, the plurality of these never even crossed my mind, so great catch there. Will also verify no code/code tags are needed in here per your comment on the Data PR.

andyjohnson commented 8 years ago

Ok, fixed the comments and a couple stray section references (making a new issue on this). Most of #973 is now in here - just have to apply to the rest of the parts.

garemoko commented 8 years ago

Checked the specific things I flagged last time and gave the rendered version a quick glance over.

+1

ljwolford commented 8 years ago

Gave it a quick read through, didn't notice anything glaring. +1