Closed andyjohnson closed 8 years ago
Added a couple of comments, otherwise looks good.
Thanks for this, Andrew. Going to fix the id(s) - Honestly, the plurality of these never even crossed my mind, so great catch there. Will also verify no code/code tags are needed in here per your comment on the Data PR.
Ok, fixed the comments and a couple stray section references (making a new issue on this). Most of #973 is now in here - just have to apply to the rest of the parts.
Checked the specific things I flagged last time and gave the rendered version a quick glance over.
+1
Gave it a quick read through, didn't notice anything glaring. +1
I realized I didn't have a new branch when I started editing the first lines and navigated away, figuring it would cancel. That first commit may be that. I simply repeated in the next commit, so hopefully nothing wonky happened in there. Look in each commit for notes. Thanks!