search

adlnet / xAPI-Spec

The xAPI Specification describes communication about learner activity and experiences between technologies.
https://adlnet.gov/projects/xapi/
905 stars 405 forks source link

two definitions of profile #969

Closed garemoko closed 8 years ago

garemoko commented 8 years ago

Fixes #967

Will probably conflict #961 and should be merged after.

andyjohnson commented 8 years ago

+1

bscSCORM commented 8 years ago

This is an improvement, and therefore 👍 to merging it, however I don't think it's the complete / best resolution of #967. Note that pretty much everywhere we use meaning 1 of profile, we are using it together with API, eg: "Activity Profile API"

So I have 2 suggestions related to this

1) Instead of having parts 1) and 2) for the definition of "profile", define "profile" and "Profile API" as distinct terms.

2) the word "API" in this context is confusing, since xAPI itself is an API and it's not really another API we're defining. We should probably rather be talking about, for example, the "Activity profile resource".

garemoko commented 8 years ago

See discussion back at the issue too. Seems this PR needs a lot more work. I might re-do it once #961 merges, but lets leave this open for now.