Closed andyjohnson closed 8 years ago
@andyjohnson I added some comments inline. The main thing (and this probably applies to the otehr PRs too) is that you can't use the code markdown (or any markdown) inside of html tags such as tables and html links. Use <code></code>
instead.
You also can't use markdown within code blocks. It's either code OR a link - it can't be both.
Code blocks within headings sort of work, but look weird.
I suggest you have a go at working through all those in each PR, then do a visual check of the rendered version. Once you've done that, I'll have another check to hopefully pick up anything you miss.
@garemoko thanks for all of your help on these! All comments addressed, all missing code blocks placed (hopefully). I'm okay with the quoted and coded "I did this" turned out.
I didn't re-review this in detail, but I did do a quick visual check over. +1
Checked some links and sent some notes. but this looks good to me. +1
Check the commit comments for questions/oddities