search

adlnet / xAPI-Spec

The xAPI Specification describes communication about learner activity and experiences between technologies.
https://adlnet.gov/projects/xapi/
901 stars 405 forks source link

1.0.3 grammar style data #971

Closed andyjohnson closed 8 years ago

andyjohnson commented 8 years ago

Check the commit comments for questions/oddities

garemoko commented 8 years ago

@andyjohnson I added some comments inline. The main thing (and this probably applies to the otehr PRs too) is that you can't use the code markdown (or any markdown) inside of html tags such as tables and html links. Use <code></code> instead.

image

You also can't use markdown within code blocks. It's either code OR a link - it can't be both.

image

Code blocks within headings sort of work, but look weird.

image

I suggest you have a go at working through all those in each PR, then do a visual check of the rendered version. Once you've done that, I'll have another check to hopefully pick up anything you miss.

andyjohnson commented 8 years ago

@garemoko thanks for all of your help on these! All comments addressed, all missing code blocks placed (hopefully). I'm okay with the quoted and coded "I did this" turned out.

garemoko commented 8 years ago

I didn't re-review this in detail, but I did do a quick visual check over. +1

cr8onski commented 8 years ago

Checked some links and sent some notes. but this looks good to me. +1