search

adlnet / xAPI-Spec

The xAPI Specification describes communication about learner activity and experiences between technologies.
https://adlnet.gov/projects/xapi/
901 stars 405 forks source link

Prefer "Total Learning Architecture" #992

Closed oconnetf closed 7 years ago

oconnetf commented 7 years ago

Fixes https://github.com/adlnet/xAPI-Spec/issues/988.

andyjohnson commented 7 years ago

Yep, thanks for this change. +1.

garemoko commented 7 years ago

Why the change in line length?

oconnetf commented 7 years ago

Honestly, this came from our internal doc practice from GitHub. I think I did it reflexively more than consciously.

When editing docs, if each sentence is a full line, it's much easier to see changes within a given sentence.

I'm happy to unwind to something more closely resembling original line lengths.

garemoko commented 7 years ago

The spec has some specific-ish line lengths which are basically about the width of a normal sized window when viewing the markdown. In fact @andyjohnson recently went through and adjusted a large number of lines to make the lengths the same.

I can definitely see the logic in your approach but 'that's not the way we do things round here' and consistency is more important.

oconnetf commented 7 years ago

Point taken. Edit made. Change committed.

garemoko commented 7 years ago

+1

andyjohnson commented 7 years ago

+1 and merging. Thanks for the catch in the line breaks.