Resolves #117, adds proper support for binary attachments

adlnet / xAPIWrapper

Wrapper to simplify communication to an LRS

https://adlnet.gov/projects/xapi/

Apache License 2.0

219 stars 114 forks source link

Resolves #117, adds proper support for binary attachments #118

Closed brian-learningpool closed 5 years ago

brian-learningpool commented 5 years ago

This corrects the issue with binary file corruption and incorrect SHA2 values.

It does this by accepting attachments as an Array Buffer and transmitting them as a multipart 'binary' transfer.

The 'text-encoding' package has been added for IE support.

brian-learningpool commented 5 years ago

Note that this PR adds the text-encoding package to allow IE to support binary attachments. Run npm install to install the package and grunt to rebuild the minified xAPIWrapper JS.

vbhayden commented 5 years ago

I'll review these today, it's been surprisingly hectic for a holiday season. 😑