oliverfoster
commented
5 years ago As I'm unable to attend the meeting on Wednesday, here's a short summary of where this PR is currently:
Works completed
- Achieved all of the above mentioned goals for the legacy branch.
- Found that
Object.keyshas been used in places which wasn't introduced until IE9 and so stops IE8 support, have applied alocalpolyfill where necessary. - The useWrapper.html and tests both use jquery v2 which isn't IE8 compatible, I've reverted to jquery v1 and now the useWrapper.html works in IE8.
- The useWrapper.html had a bad preventDefault on radio selections which caused the interface to behave oddly in IE8, which I've fixed.
Outstanding works
- Check working in IE9.
- The
shouldlibrary doesn't support IE8 as it uses getter functions which weren't introduced until IE9. - Find a potential replacement assertion library to cover IE8 or remove the assertion library altogether.
- Rework the tests so that they perform.
doxstraplibrary has a bug in node 10 for which I've an outstanding PR. This impacts the master branch also, preventinggrunt docsdocument creation.- Need to version bump
doxstrapto v0.0.8 in master.
Summary
With the changes it looks to be working in IE8 and potentially IE9, it just needs some finer testing. grunt docs production will need someone upstream to accept the pr mentioned above or the doxstrap library will need replacing.
Legacy
Remove IE10+ only code from legacy branch to prove support for <=IE9doneAdd ADL.dateToISOString to complement ADL.dateFromISOString for example.html as Date.prototype.toISOString shim will be removedAs per comment browser polyfills are prefered.Remove functions from global scopedonemaster