Resolves #153, prevents LRS grouping from overwriting existing groupings

adlnet / xAPIWrapper

Wrapper to simplify communication to an LRS

https://adlnet.gov/projects/xapi/

Apache License 2.0

214 stars 114 forks source link

Closed brian-learningpool closed 4 years ago

adl-trey commented 5 years ago

Tracking, busy week but will review when I can.

brian-learningpool commented 4 years ago

Hi @adl-trey, sorry to be a pest but I was wondering if you would know when this might be reviewed?

adl-trey commented 4 years ago

Oh not at all! We've been buried in I/ITSEC prep and other popups so a reminder is welcomed. I'll try and get to this today.

vbhayden commented 4 years ago

Looking at this now, not really familiar with the context property so I'll be reading up on that for a bit to make sure nothing weird's going on.

vbhayden commented 4 years ago

Ok, I don't see anything wrong with this, merging and will update the Readme / dist shortly.

brian-learningpool commented 4 years ago

Thanks!