Upgrade dev dependencies

adlnet / xAPIWrapper

Wrapper to simplify communication to an LRS

https://adlnet.gov/projects/xapi/

Apache License 2.0

219 stars 114 forks source link

Upgrade dev dependencies #156

Closed jsma closed 5 years ago

jsma commented 5 years ago

npm audit recommends that these packages should be upgraded:

found 33 vulnerabilities (10 low, 17 moderate, 6 high) in 448 scanned packages
  run `npm audit fix` to fix 12 of them.
  21 vulnerabilities require semver-major dependency updates.

FlorianTolk commented 5 years ago

Can you reminify the wrapper after updating these files?

jsma commented 5 years ago

Sure! Should the version number be incremented?

FlorianTolk commented 5 years ago

Let's upgrade it to version 1.11.0 Good call! Thanks!

jsma commented 5 years ago

Another hopefully quick question, I updated one block in the README showing how to include the source files into a project but just noticed that it's repeated below in https://github.com/adlnet/xAPIWrapper/blob/master/README.md#xapi-launch-support

Should the duplication be removed or merely updated to match?

FlorianTolk commented 5 years ago

I don't see the duplication anywhere

jsma commented 5 years ago

This section is what I updated in this PR (screen shot taken from master):

Then below is the following section which also repeats:

FlorianTolk commented 5 years ago

Ahh, thanks. Let's update this in case there are folks that just bookmarked this section for their personal use.