adlnet / xAPIWrapper

Wrapper to simplify communication to an LRS
https://adlnet.gov/projects/xapi/
Apache License 2.0
219 stars 114 forks source link

getStatements with attachments #77

Closed ljwolford closed 6 years ago

ljwolford commented 7 years ago

getStatements always expects JSON back in the response, even for when using the attachments query. Is it worth discussing this a bit more to have it parse out the statement and do something with the attachments?

vbhayden commented 6 years ago

The user / team requesting statement attachments will be most familiar with decoding the specific file-type that statement should've had attached. We can look into it down the road, but for now it feels like a pretty heavy lift to account for any generic file that may have been attached and how to decode them.

The wrapper currently conforms to the Spec, but does leave room for improvement as you pointed out.