search

adlnet / xAPIWrapper

Wrapper to simplify communication to an LRS
https://adlnet.gov/projects/xapi/
Apache License 2.0
219 stars 114 forks source link

ADL.launch not compatible with IE #97

Closed danielghost closed 5 years ago

danielghost commented 7 years ago

Looks like the ADL.launch method makes use of the URL API which is not supported by IE. This means the current code cannot initialize the launch.

vbhayden commented 6 years ago

Good Afternoon!

I've been going through some of the cold-case issues to clean up the issues page. What are the steps someone would follow to recreate the behavior you're experiencing?

-Trey

brian-learningpool commented 6 years ago

Hi @vbhayden, I think what @danielghost is referring to is that fact that lines like https://github.com/adlnet/xAPIWrapper/blob/master/src/xapi-launch.js#L130 have:

var launch = new URL(launchEndpoint);

The URL API is not supported in IE 11, so the code will always fall over in this line. (See https://caniuse.com/#search=url)

vbhayden commented 6 years ago

Oh good find, I'll look at that today.

On an unrelated note, ADL has been consumed by this year's TLA implementation for the last 4 months, so we should be a bit more responsive now that it's concluded. :-)

brian-learningpool commented 6 years ago

Hi Trey, good to know. 👍