search

adlnet / xapi-authored-profiles

Repository of official xAPI Profiles
https://adlnet.gov/projects/xapi/
Apache License 2.0
44 stars 45 forks source link

Adding eLearning-courseware profile #34

Closed Dustin-Walker closed 6 years ago

Dustin-Walker commented 7 years ago

Submitting xAPI eLearning courseware profile.

fugu13 commented 7 years ago

Hi Dustin, this looks great! I've added a few minor comments

Dustin-Walker commented 7 years ago

All of the requested changes have been made.

Dustin-Walker commented 7 years ago

Does anything else need to be done on this PR?

jhaag75 commented 6 years ago

Just curious...how is this profile different than existing eLearning profiles such as SCORM and CMI5? The term "eLearning" is quite broad and not very specific to a particular use case. Many types of things qualify as "eLearning" so what problem is this particular profile focused on? The profile description mentions IMI Level 3. The name of this profile is too general. Is it designed to work in a specific xAPI Implementation, system, or company's application? If so, then that should be the title of the profile.

The IRIs should also follow the https://w3id.org/xapi pattern suggested in the profile spec and at http://xapi.vocab.pub.

Besides that I think the general authoring of the profile looks good. Let us know if we can help or if you want to discuss any of this over the phone.

fugu13 commented 6 years ago

Hi Dustin, apologies it took so long to get back to you. I've been quite busy and am currently doing profile things on a volunteer basis (I'm available for consulting on this and other things, btw). Re: URIs, if these are URIs you've been using, the profile should use them, not change to w3id, but if these are new URIs then updating to use w3id URIs is probably a good idea. Doing a quick review of the rest now.

fugu13 commented 6 years ago

The only thing I see that needs changing before merge is the id and type thing. Everything else is fine as is

fugu13 commented 6 years ago

Nick Washburn mentioned that this was intended to be a generic profile in the xAPI TAG call today, if I'm understanding. If that's the case, I think you'll want to make some additional revisions. For example, this profile requires the use of an mbox/email, but that's not something a generic profile would require. My assumption before was that this was a Riptide-specific profile.

jhaag75 commented 6 years ago

Agree w/ @fugu13. This should not be called an eLearning profile. It should be called a riptide elements profile or something pertaining to your implementation.

The SCORM and cmi5 profiles are more along the lines of reusable eLearning course profiles. However, if you want your customers using your software to have a reusable profile that's fine too. It's just not as broad as SCORM or CMI5 IMO.

vbhayden commented 6 years ago

Agreed, this is too generic of a name. As the name change is a simple fix and nothing has been done with this in almost 3 months, I don't see why this should remain an open PR.