search

adlnet / xapi-authored-profiles

Repository of official xAPI Profiles
https://adlnet.gov/projects/xapi/
Apache License 2.0
42 stars 44 forks source link

DOD ISD Profile #48

Closed jhaag75 closed 6 years ago

jhaag75 commented 6 years ago

@oconnetf @CAEUSAISG

You might want to pull down a copy from the master. I updated the versioning numbers to match semantic versioning (per these guidelines: http://xapi.vocab.pub/resources/index.html).

The JSON doc has several validation errors. Before I can import this into xapi.vocab.pub can you fix the JSON? You can use JSON Lint or some other JSON formatter.

oconnetf commented 6 years ago

Thanks, @jhaag75. Didn't think to re-lint it after adding multi-line definition entries.

Speaking of which, I wonder if we should add clarity to the examples in the templates? I think in a copy/paste way, those examples might include invalid JSON.

jhaag75 commented 6 years ago

The examples should be valid. It's special characters in your profile that aren't validating, I think.

On Feb 13, 2018 7:56 AM, "oconnetf" notifications@github.com wrote:

Thanks, @jhaag75 https://github.com/jhaag75. Didn't think to re-lint it after adding multi-line definition entries.

Speaking of which, I wonder if we should add clarity to the examples in the templates? I think in a copy/paste way, those examples might include invalid JSON.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adlnet/xapi-authored-profiles/issues/48#issuecomment-365273465, or mute the thread https://github.com/notifications/unsubscribe-auth/AAiZRsPJjo7PDEvlYNNYS0gLsFpxz6k3ks5tUZR-gaJpZM4SADuK .