adlnet / xapi-authored-profiles

Repository of official xAPI Profiles
https://adlnet.gov/projects/xapi/
Apache License 2.0
42 stars 44 forks source link

Updated Profile Per cmi5 Meeting March 13, 2020 #86

Closed MrBillMcDonald closed 4 years ago

MrBillMcDonald commented 4 years ago

Updated Profile Per cmi5 Meeting March 13, 2020 to accurately reflect portions of the cmi5 spec that map to an xAPI authored profile.

Some cmi5 spec requirements (such has conditional behavior) can not be expressed in terms of an xAPI authored profile and are explained in scope notes/descriptions where possible.

Deferred, patterns and templates until profile server design is finalized.

vbhayden commented 4 years ago

Morning Bill,

Florian's OOO today so I'll look this over.

vbhayden commented 4 years ago

No syntax issues so I'll go ahead and merge. On that note, I'm not too familiar with cmi5 but was surprised to see

"https://w3id.org/xapi/cmi5#satisfieds"

declared / referenced like that. It's not used consistently within its own pattern definition of:

{
    "id": "https://w3id.org/xapi/cmi5#satisfieds",
    "type": "Pattern",
    "prefLabel": {
        "en": "Satisfieds"
    },
    "inScheme": "https://w3id.org/xapi/cmi5/v1.0",
    "zeroOrMore": "https://w3id.org/xapi/cmi5#satisfied"
},

so I'm not sure how the plural satisfieds gained use, even with the singular satisfied being used in that same definition.

Additionally, small typo on 675 ("alernates"):

"definition": {
    "en": "This pattern provides an option to use zero or more of the alernates for the Typical Session pattern."
},