adlnet / xapi-authored-profiles

Repository of official xAPI Profiles
https://adlnet.gov/projects/xapi/
Apache License 2.0
42 stars 44 forks source link

Use of "related" in a Concept #88

Open cliffcaseyyet opened 4 years ago

cliffcaseyyet commented 4 years ago

Hello,

While testing a new automated xAPI Profile validator, we noticed that there was a potential conformance issue in a number of profiles in this repo.

Specifically, the use of "related".

For example, in acrossx/acrossx.jsonld on line 252

{
"id": "https://w3id.org/xapi/acrossx/verbs/liked",
"type": "Verb",
"related": [ "http://activitystrea.ms/schema/1.0/like" ],
"exactMatch": [ "http://activitystrea.ms/schema/1.0/like"
...

According to spec, the "related" property MUST only be used on Concepts that are deprecated to indicate possible replacement Concepts in the same Profile, if there are any.

Below are the instances we found. In any case where we found an issue, either the referenced Concept was from another Profile or the containing Concept was not set as deprecated:

acrossx/acrossx.jsonld | line 252 activity-streams/activity-streams.jsonld | line 524 activity-streams/activity-streams.jsonld | line 1118 activity-streams/activity-streams.jsonld | line 1284 adb/adb.jsonld | line 73 adb/adb.jsonld | line 96

We wanted to share in case you were unaware of the issue.

Thanks, Cliff Casey