search

adlnet / xapi-profiles

A set of documents addressing the structure of and supporting services for xAPI Profiles.
https://adlnet.gov/projects/xapi/
Apache License 2.0
54 stars 27 forks source link

Update to published profiles & activity context #234

Closed jhaag75 closed 7 years ago

jhaag75 commented 7 years ago

Moved activity-context.jsonld to "context" folder

fugu13 commented 7 years ago

The .DS_Store files need to be removed from the PR (and .DS_Store added to .gitignore)

fugu13 commented 7 years ago

Really, please don't push directly to main repo master. I think there's something in github settings you can change to make it not possible (might only stop force pushes, not sure). Making changes only via PR creates better documentation of changes and prevents a wide range of bad situations that are easy to prevent with PR process that ensures changes only flow one direction (local branch -> fork branch -> main repo master -> local master -> local branch)

jhaag75 commented 7 years ago

thanks Russell. Makes sense. Let's open an issue and I'll move them to their own repo.

On Aug 18, 2017 3:25 PM, "fugu13" notifications@github.com wrote:

@fugu13 commented on this pull request.

In profiles/README.MD https://github.com/adlnet/xapi-profiles/pull/234#discussion_r134048334:

@@ -0,0 +1,7 @@ + +This is the main repo page for published JSON-LD profiles for xAPI.

I think "main repo page" is going to be confusing.

Also, I strongly recommend not lumping actual profiles in with the spec. That's going to make maintainability very bad, both for the spec and the profiles. Really each profile should have its own repo, or possibly if one group is managing multiple closely related profiles maybe a single repo for those.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/adlnet/xapi-profiles/pull/234#pullrequestreview-57304063, or mute the thread https://github.com/notifications/unsubscribe-auth/AAiZRoq--5fx6X-cb_co2mlHv7gU6k6sks5sZfNBgaJpZM4O5Zy5 .