adlnet / xapi-profiles

A set of documents addressing the structure of and supporting services for xAPI Profiles.
https://adlnet.gov/projects/xapi/
Apache License 2.0
54 stars 27 forks source link

Fix Type for optional, oneOrMore and zeroOrMore in Patterns Table #250

Closed FeLungs closed 1 year ago

FeLungs commented 5 years ago

Filing an issue about the xAPI Profiles specification? Please include the following

Which part/parts of the specification are at issue?

type column value for optional, oneOrMore and zeroOrMore

Screen Shot 2019-11-20 at 15 11 26

Given above, optional, oneOrMore and zeroOrMore must be defined as

but alternates and sequence must be defined as

ideally, all pattern items should be either a URI or an Array of URI

What is your understanding of what the spec means in these parts?

Reference to "A single Pattern or Statement Template identifier"

oneOrMore Screen Shot 2019-11-20 at 15 14 50

zeroOrMore Screen Shot 2019-11-20 at 15 15 57

Related to your implementation, what's the use case you're trying to achieve? What are the user stories you're trying to support?

Removal of unnecessary Object container

How you would like the specification to be improved?

Replace object with URI for optional, oneOrMore and zeroOrMore

Property Type Description Required
optional URI ... ...
oneOrMore URI ... ...
zeroOrMore URI ... ...

@aaronesilvers, @andyjohnson this issue relates to validation of xAPI Profiles against the spec.

creighton commented 4 years ago

Agree they should be URI, also note the description for the id field should say "A URI for the Pattern"

andyjohnson commented 2 years ago

Per the 7/19/2022, group agrees- feel free to throw a PR at this (or I could too)

andyjohnson commented 2 years ago

Per the 7/19/2022 - would like to see some solid pattern examples with some logic/flow graphical support

andyjohnson commented 2 years ago

Per the 7/19/2022 - can use https://github.blog/2022-02-14-include-diagrams-markdown-files-mermaid/ to create flow within Markdown