adlogix / docker-machine-nfs

Activates NFS on docker-machine
MIT License
794 stars 104 forks source link

Added vmware fusion support for default docker-machine NAT configuration #26

Closed ckortekaas closed 8 years ago

ckortekaas commented 8 years ago

Hi, I this works with the basic NAT setup that docker-machine/vmware fusion seems to use, and solves the problem of NFS + VMWare fusion.

Also I had to add nfs.server.mount.require_resv_port = 0 to OSX /etc/nfs.conf otherwise I got a NFS mount error about weak credentials. This is referenced in 'another' docker-machine-nfs.sh in their code here: https://gist.github.com/olalonde/3f7512c0bd2bc8abb46d so it might be worth adding that too, but probably as a separate PR as it's not a unique problem to vmware fusion support.

ckortekaas commented 8 years ago

My IDE removed some extraneous spaces in this commit. I hope that's ok.

adambiggs commented 8 years ago

I just checked out your branch and tried it out on my VMware Fusion machine.

At first it didn't work, but after adding nfs.server.mount.require_resv_port = 0 to /etc/nfs.conf as you mentioned in your previous PR, it works!

I think it'd be best if the script took care of this part to make it a complete solution.

Thanks again!

ckortekaas commented 8 years ago

@adambiggs ok I've added the nfs.conf changes, rebased, squashed and I think it looks pretty good. Let me know if you need anything else.

ckortekaas commented 8 years ago

By the way, if you accept this commit, you should probably change the description of the repo from 'Activates NFS on docker-machine virtualbox' to 'Activates NFS on docker-machine virtualbox, vmware fusion, and parallels'?

adambiggs commented 8 years ago

Sorry @ckortekaas, I'm not actually a maintainer of this project... didn't want to give you the wrong impression.

But hopefully @tonivdv can merge this soon because it's working great for me!

tonivdv commented 8 years ago

Hey @ckortekaas ,

First of all sorry for the late reaction. Got some important stuff to finish before end of the year. Second many thanks for the contribution. I downloaded a trial version of vmware fusion and it worked immediately :+1:

Merry Christmas ;)

adambiggs commented 8 years ago

Nice! Thanks guys!

:christmas_tree: