search

adlogix / docker-machine-nfs

Activates NFS on docker-machine
MIT License
794 stars 104 forks source link

The script mentions boot2docker. #8

Closed squaresurf closed 8 years ago

squaresurf commented 9 years ago

It is confusing to read the function declarations that mention boot2docker, but as far as I can tell boot2docker is not used. Since docker-machine is the future, it would be best to refactor so that boot2docker is not mentioned.

silvamerica commented 9 years ago

Docker Machine still uses the boot2docker.iso under-the-hood for creating a Virtual machine locally, so many of the comments still make sense in that context.

squaresurf commented 9 years ago

Some of the function names do not make sense though:

:point_up: do not start or configure boot2docker.

squaresurf commented 9 years ago

I can open a PR in a bit if no one is opposed to it. I wanted to get some input first though to make sure I was understanding it all correctly.

silvamerica commented 9 years ago

For sure. I agree that the comments (especially the user-facing ones) can be updated, but I just wanted to make sure that you and other readers of this issue understand that boot2docker is still used even though it is through docker-machine.

squaresurf commented 9 years ago

Awesome, I didn't realize that. Does it make sense to you to update any references to boot2docker with docker-machine unless it is in reference to the iso?

silvamerica commented 9 years ago

That sounds reasonable to me. If you'd like, I can review the PR if you cc me.

On Fri, Sep 18, 2015 at 9:49 AM, Daniel Searles notifications@github.com wrote:

Awesome, I didn't realize that. Does it make sense to you to update any references to boot2docker with docker-machine unless it is in reference to the iso?

— Reply to this email directly or view it on GitHub https://github.com/adlogix/docker-machine-nfs/issues/8#issuecomment-141505290 .