Fix #8 - Githubissues

adlogix / docker-machine-nfs

Activates NFS on docker-machine

MIT License

794 stars 104 forks source link

Fix #8 #9

Closed squaresurf closed 8 years ago

squaresurf commented 9 years ago

Why:

It is confusing to read the script and see references to boot2docker that are not in the context of the boot2docker.iso. It makes it appear as though this uses the boot2docker command when in reality it uses docker-machine.

This change addresses the need by:

Refactor applicable boot2docker refences to use Docker Machine.

squaresurf commented 9 years ago

Here ya go @silvamerica :smile:

squaresurf commented 8 years ago

@tonivdv, I'm sorry it took me so long to respond as my wife had a baby ~ 2 weeks ago and I've been offline.

I've changed the function back to use boot2docker in the name of the configure function as it is more explicit. I then added to the comment to give context. Let me know what you think.

tonivdv commented 8 years ago

Hey @squaresurf ,

Congrats for the baby. I'll be in the same 'situation' any time now ;) ... baby boom on github :D

The changes are good, if you could just squash the commits and then all merge the PR.

Cheers

squaresurf commented 8 years ago

Congrats on the baby @tonivdv :smile:

I just squashed so this should be good to go.

tonivdv commented 8 years ago

Thanks for contributing.