adlogix / docker-machine-nfs

Activates NFS on docker-machine
MIT License
794 stars 104 forks source link

Support docker-machine-driver-vmware and use machine ip for route #95

Closed weikinhuang closed 5 years ago

weikinhuang commented 5 years ago

Add support for the new vmware driver for docker-machine https://github.com/machine-drivers/docker-machine-driver-vmware which supports vmware fusion 11.

Also fix the route detection for the docker-machine/nfs host ip address to improve security of the nfs export. This change makes it so the boot2docker vm only tries to access the nfs mount over the vmnet nat interface and have the nfs host only export the /Users directory to the docker machine in question instead of anyone having access to the host ip.

This also fixes an issue in a corporate environment where IPs can change based on connecting/disconnecting to/from a vpn.

bossjones commented 5 years ago

FYI, I created a brew tap w/ these fixes for the time being until this PR gets merged. Thank you guys for your hard work on this.