adlr / croshwindow

Crosh Window opens a new Crosh window without any chrome so that Ctrl-N/T/etc work. Chrome OS only.
41 stars 19 forks source link

Can only open one window now #3

Open WayneD opened 10 years ago

WayneD commented 10 years ago

The latest Chrome OS beta makes it impossible to open more than one crosh window at a time. After starting up the first instance the shelf icon for Crosh Window is now highlighted (not the Secure Shell icon, like Chrome OS used to do). Right-clicking shows no "New Window" choice in the menu. Thus, there is no way to start up a second instance. Can this be fixed?

adlr commented 10 years ago

Does Ctrl-Shift-N make a new window?

On Fri, Apr 11, 2014 at 10:51 AM, Wayne Davison notifications@github.comwrote:

The latest Chrome OS beta makes it impossible to open more than one crosh window at a time. After starting up the first instance the shelf icon for Crosh Window is now highlighted (not the Secure Shell icon, like Chrome OS used to do). Right-clicking shows no "New Window" choice in the menu. Thus, there is no way to start up a second instance. Can this be fixed?

Reply to this email directly or view it on GitHubhttps://github.com/adlr/croshwindow/issues/3 .

WayneD commented 10 years ago

It creates a window that has an unstyled ssh open dialog, which doesn't seem to let me choose something to open.

I'm currently using a ">crosh" ssh connection to get a second window, but since that doesn't give me the ability to write text into the title bar, I'd prefer to get a second Crosh Window instead (like before).

Perhaps the Secure Shell folks could fix Ctrl-Shift-N to make things selectable (since the title-bar is right in the new window, though the dialog is not usable). Sadly, I reported that issue to them months ago, and it seems they didn't fix it yet.

adlr commented 10 years ago

Ah, I see the problem. Are you able to look at the code for Crosh Window and see if you can tweak it to fix it? It's basically a 1-liner, so that may be easiest.

Alternatively, you could look at the Secure Shell code and see if you can make ctrl-shift-N on a crosh window open up a new crosh window rather than a ssh window.

On Fri, Apr 11, 2014 at 11:06 AM, Wayne Davison notifications@github.comwrote:

It creates a window that has an unstyled ssh open dialog, which doesn't seem to let me choose something to open.

I'm currently using a ">crosh" ssh connection to get a second window, but since that doesn't give me the ability to write text into the title bar, I'd prefer to get a second Crosh Window instead (like before).

Perhaps the Secure Shell folks could fix Ctrl-Shift-N to make things selectable (since the title-bar is right in the new window, though the dialog is not usable). Sadly, I reported that issue to them months ago, and it seems they didn't fix it yet.

Reply to this email directly or view it on GitHubhttps://github.com/adlr/croshwindow/issues/3#issuecomment-40236040 .

WayneD commented 10 years ago

Yeah, I was thinking that overriding Ctrl-Shift-N in Secure Shell might be a nice fix. I'm not sure how to affect the shelf's pop-up menu, though. Perhaps a simple change to the manifest of Crosh Window? I can do some searching and see if I find anything to try.

I've just discovered a work around that gets me back to the usable title-bar: If I start up a crosh window via ssh and then use Ctrl-Shift-N from that window, I get what I want (and can close the original window). That works for the moment while we try to make this better.

WayneD commented 10 years ago

Here's something else that works, but is slightly sub-optimal: I'm testing a version with a manifest set to launch an app (instead of create a background script). I added an html page that just imports a slightly tweaked main.js script which opens the crosh.html window and closes the app window. So, the bad things about this are that an extra window blips onto the screen when starting up and that the user needs to pick the "open as window" choice in the right-click menu for the Crosh Window app in order for Ctrl-N to behave properly in the created window (not sure why that is). That said, it at least works like before (allows multiple clicks for multiple windows, and the window(s) end up attached to the Secure Shell icon). I checked in my changes here: https://github.com/WayneD/croshwindow

Let me know if you want a pull request. There might be some additional refinement that could be done before going with this method. e.g. I tried to find a way to make the app window default to being hidden, but didn't see anything.

adlr commented 10 years ago

Hey, @WayneD, sorry for the delay. Yeah, sounds good. Send a pull request over!

adlr commented 10 years ago

So, unfortunately, I can't upload this to the web store b/c they don't allow change from a platform app to a hosted app. Would you be able to make this change work with a 'background' section in the manifest? Hopefully the app store will allow that change to be uploaded.

WayneD commented 10 years ago

I tried changing it back to a background window that opens another window (closing the first), but both the windows are associated with the extension's icon, and thus it doesn't help in the creation of new windows. You may just want to release a new extension (Crosh Windows?) with the new app style and let folks choose the one they like.

badboy commented 10 years ago

Any updates to this? I don't use my Chromebook frequently, so I just came across this issue.

WayneD commented 10 years ago

If you don't want to dev-load my extension on your chromebook, the easiest thing you can do is to use the crosh support in Secure Shell: save a connection with user "run" and host ">crosh" (including the leading ">"). That gives you a crosh window when you choose it. Since I like a titlebar that I can put text into, I personally use Ctrl-Shift-N to create a subwindow and close the initial window (from then on using Ctrl-Shift-N to get extra windows). However, if you like the no-text titlebar, you can instead right-click the icon and ask for each new window.

adlr commented 10 years ago

Whoa, I didn't know about run >crosh.

Maybe Crosh Window should change to just showing instructions for that.

badboy commented 10 years ago

Thanks, @WayneD, will try that later.

zerongjiang commented 9 years ago

Set host to >crosh works!

Thnkas @WayneD