search

adm78 / visualchemeng-js

JavaScript modules for visualchemeng.com
http://visualchemeng.com/
MIT License
13 stars 3 forks source link

Rename ParticleFeed to avoid confusion with physical feeds to unit operations #36

Closed adm78 closed 5 years ago

adm78 commented 5 years ago

Currently the fact that we have physical feeds (say, the real feed to a distillation column with component concentrations and a temperature) and graphical feeds (i.e. somewhere where we generate particle entities which become part of an ensemble to give a graphical effect). It would be better it we called them something different entirely. Say, change the graphical version of the feed to ParticleSource , GraphicalFeed or GraphicalParticleSource.

This also highlights a potential need to split up the graphical and physical components with the vce library. However, some apps (namely the molecular dynamics app) blur the line between these two things. Needs a bit more though.

adm78 commented 5 years ago

Fixed in commit e724764ecdf0c7fc9439d904b1f1e20593b1ebef