search

admb-project / admb

AD Model Builder
http://admb-project.org
Other
64 stars 19 forks source link

Update NUTS MCMC routine to fix bugs, improve efficiency, and add new dense mass matrix adaptation #146

Closed Cole-Monnahan-NOAA closed 4 years ago

Cole-Monnahan-NOAA commented 4 years ago

Tests were also added in the 'tests/adnuts' folder. No changes to core ADMB files, only MCMC routines, tests, and CHANGE log.

codecov[bot] commented 4 years ago

Codecov Report

Merging #146 into master will increase coverage by 1.79%. The diff coverage is 65.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   52.95%   54.74%   +1.79%     
==========================================
  Files         602      601       -1     
  Lines       53884    53704     -180     
==========================================
+ Hits        28533    29401     +868     
+ Misses      25351    24303    -1048
Impacted Files Coverage Δ
src/nh99/admodel.h 0.00% <ø> (ø)
src/nh99/hmc.cpp 0.00% <0.00%> (ø)
src/nh99/modspmin.cpp 63.58% <ø> (+8.21%) :arrow_up:
src/nh99/rwm.cpp 57.11% <57.11%> (+57.11%) :arrow_up:
src/nh99/nuts.cpp 69.58% <69.58%> (+69.58%) :arrow_up:
src/nh99/hmc_functions.cpp 85.28% <85.71%> (+79.46%) :arrow_up:
src/nh99/montebds.cpp 8.84% <0.00%> (+3.98%) :arrow_up:
src/nh99/mod_mc1.cpp 34.04% <0.00%> (+14.89%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb131f5...af121b0. Read the comment docs.

johnoel commented 4 years ago

Still needs a test for -hmc option for adnuts. Coverage for the other files could be better, but okay for now.