search

admb-project / admb

AD Model Builder
http://admb-project.org
Other
64 stars 19 forks source link

Update error messages in read_mle_hmc function to be more informative #161

Closed Cole-Monnahan-NOAA closed 3 years ago

Cole-Monnahan-NOAA commented 3 years ago

Update error messages in a single HMC function. No change to functionality or logic.

codecov[bot] commented 3 years ago

Codecov Report

Merging #161 (f52aedd) into master (d87b7d1) will increase coverage by 0.00%. The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   47.99%   48.00%           
=======================================
  Files         729      729           
  Lines       61608    61607    -1     
=======================================
+ Hits        29571    29572    +1     
+ Misses      32037    32035    -2
Impacted Files Coverage Δ
src/nh99/hmc_functions.cpp 85.67% <20.00%> (+0.51%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d87b7d1...f52aedd. Read the comment docs.

johnoel commented 3 years ago

Can you look at the scanned code warnings for nuts.cpp and rwm.cpp?

https://github.com/admb-project/admb/security/code-scanning

Cole-Monnahan-NOAA commented 3 years ago

That link doesn't work for me (404). Do you mean the unused variable warnings when compiling those files?

johnoel commented 3 years ago

@Cole-Monnahan-NOAA, can you resend the pull request to branch/admb-12.3?

johnoel commented 3 years ago

Changes in f52aedd will be added pull request #182.