search

admb-project / admb

AD Model Builder
http://admb-project.org
Other
64 stars 19 forks source link

Update console output options and default #220

Closed Cole-Monnahan-NOAA closed 2 years ago

Cole-Monnahan-NOAA commented 2 years ago

This is a comprehensive update to two aspects of ADMB.

(1) Improved console output as discussed at https://github.com/admb-project/admb/discussions/219 , including bound checking to console and file from issue https://github.com/admb-project/admb/issues/221. In order to print parameter names to console much code was modified/added by @Cole-Monnahan-NOAA and @wStockhausen. This works for ADMB, random effects, and autodiff models.

Bound checking is done immediately after optimization completes in the final phase, before any Hessian calculations, and will not be invoked when using options like MCMC. See PR https://github.com/Cole-Monnahan-NOAA/admb/pull/3

These changes should have no impact on the logic of the code and thus no downstream impacts on statistical function. It should only change console output, and the old way can be had with argument "-output 2". If this option fails, ADMB will exit early. In this case the user should report the situation and rerun with -output 2 which does not invoke any of the new code and thus be unaffected.

"-output 0" will disable all standard output (but show errors and such) "-output 1" is the new more compact output that suppresses much of the original output, and provides alternative warning/error messages. "-output 2" is the original output (still default, but will recommend users test -output 1)

(2) Updates to the hess_step feature. Mostly console output improvements, but also some small logical changes, including a change to default max N steps.

johnoel commented 2 years ago

Pull #235 will replace this since merge will go to dev branch instead of master.