admb-project / admb

AD Model Builder
http://admb-project.org
Other
64 stars 19 forks source link

Add new test model to catch run time errors #233

Closed Cole-Monnahan-NOAA closed 2 years ago

Cole-Monnahan-NOAA commented 2 years ago

I think it would be wise for developers to have a test model which includes:

The model will run trivially fast, and this is not a statistical test. It would be designed to catch runtime errors. The main idea is to find edge cases where new features may fail but are not in the current test suite.

@wStockhausen any other ideas to add?

@johnoel if you can build the variable type part and how to integrate it in as a test I can help with the other parts

johnoel commented 2 years ago

So, you want something like make verify, but all put into a single model?

Cole-Monnahan-NOAA commented 2 years ago

No I meant to add a new model to the make verify suite. The point is that the current set of test models don't necessarily cover a wide usage and combination of features. It appears to me that they're setup from real statistical examples and so have a lot of similarities.

So e.g., if none of the models use a 4d array type, and our new output stuff breaks on those, we won't know until it's released. This would be most useful for developers to have a faith that a new feature or bug fix doesn't break some unusual model setup.