admb-project / admb

AD Model Builder
http://admb-project.org
Other
64 stars 19 forks source link

Possible typo in sqr(const dvector&) #81

Closed johnoel closed 7 years ago

johnoel commented 7 years ago

tmp.elem(i)=sqrt(v1.elem(i));

sqrt should be sqr or v1.elem(i) * v1.elem(i)?

johnrsibert commented 7 years ago

I looks like this code was duplicated from the preceding dvector sqrt(const dvector& v1) function and never correctly completed.

It should be tmp.elem(i)=sqr(v1.elem(i)); or tmp.elem(i)=v1.elem(i) * v1.elem(i) ;

Also, some dox would be helpful.