search

admc / wd

A node.js client for webdriver/selenium 2.
Other
1.53k stars 402 forks source link

wd not working properly with selenium-server-2.34.0 #167

Closed psyCodelist closed 11 years ago

psyCodelist commented 11 years ago

Hi,

I was trying to load a page with new selenium-server-2.34.0 and got no json respond error.

switched to the older version of selenium and it works fine.

Thanks,

Nima

sebv commented 11 years ago

Ok I think I know what it is, it's the init method not following strictly the JsonWire protocol spec. It didn't cause any trouble before cause all the systems where using a redirect to session mechanism. selenium-server 2.34.0 does not, which is better.

It need to be rewritten to follow redirects, and use session from data rather than from url location.

sebv commented 11 years ago

@MattiSG, do want to work on this one?

MattiSG commented 11 years ago

@sebv I most probably won't have time to do this before next Tuesday.

sebv commented 11 years ago

@MattiSG, next week is OK, just let me know if you want to do it. I really don't mind doing it, was just thinking it is a nice bug to fix if you want to know more about wd internals, request package etc...

MattiSG commented 11 years ago

@sebv Oh, I see :) Well, that's a very nice offer, but I'm afraid it is not the right time for me: I really have tons of stuff going on until mid-September, so I'd rather minimize the workload on things that are not an absolute necessity :)

sebv commented 11 years ago

Ok I'll do it myself then.

jaredly commented 11 years ago

+1

sebv commented 11 years ago

Fixed in v0.1.0.

csnover commented 11 years ago

README is not updated with the new init signature, but other than that I can confirm this update fixes the issue. Interestingly, the capabilities object to init is not provided by ChromeDriver at this time, so you still have to get it separately with sessionCapabilities.

sebv commented 11 years ago

Closing, doc will be automatically updated next doc refreshed.