search

admc / wd

A node.js client for webdriver/selenium 2.
Other
1.53k stars 402 forks source link

Remove dependency on lodash. #459

Closed rictic closed 6 years ago

rictic commented 7 years ago

A mix of ES5 methods and short expressions can replace all the lodash methods used in wd, and cuts the installed size by over a third (removing 4.8MB from the ~13MB total size of wd and its deps)

This also makes it easier to use wd in environments that don't support multiple copies of the same node library (like yarn --flat and some internal uses at google), as lodash has numerous breaking changes across major versions, and there are a number of libraries that use the v2, v3, and v4 major versions.

Leaves lodash in dev dependencies, as it's still used in the gulpfile.

jlipps commented 7 years ago

This is an interesting change, thanks @rictic. I think it will take some time to evaluate it. For example I'm not sure what I think about for ... in, we have tended to stay away from it as a construct. Probably @imurchie should weigh in, and/or @sebv.

rictic commented 6 years ago

I may come back to this, but the original PR had some issues.