Updated packages and fixed tests

admc / wd

A node.js client for webdriver/selenium 2.

Other

1.53k stars 402 forks source link

Closed Havunen closed 5 years ago

Havunen commented 6 years ago

Updated packages to latest versions, to reduce security issues reported by npm audit.
Fixed tests (rejectUnAuthorized being true by default)
Moved variable jsonData up one level as it was used inside the method.

Replaced 'spawn-mocha-parallel' package with 'gulp-spawn-mocha' as it does not seem to be maintained.

Havunen commented 6 years ago

Tests seem to pass, but its not connecting to Saucelabs, I guess SAUCE_USERNAME or ACCESSKEY is not set to process env correctly

jlipps commented 6 years ago

yeah, those env vars are secrets and therefore won't be set for jobs started b7 PRs for security reasons

jlipps commented 6 years ago

trying to run the tests locally with my own creds to see what happens

jlipps commented 6 years ago

Hi @Havunen sorry I didn't get to this earlier and now there are conflicts. Mind resolving and then I'll re-review?

admc commented 5 years ago

I took all these changes, ran the tests and just pushed in commit #b0405da33993263e69fd2af0a1402c42fa0ad4d2

Thanks again!