search

admc / wd

A node.js client for webdriver/selenium 2.
Other
1.53k stars 402 forks source link

Fix test failures #532

Closed joeyparrish closed 6 years ago

joeyparrish commented 6 years ago

This fixes linter errors, fixes tests broken by #521, and adds a note about getting chromedriver working.

joeyparrish commented 6 years ago

I found these issues while working on a PR for #495. I thought it would be best to fix these pre-existing issues separately from any protocol-related changes. Thanks!

joeyparrish commented 6 years ago

Also, JFYI, but your travis-CI config seems to be broken. It fails to connect to Sauce Labs. https://travis-ci.org/admc/wd/builds/385396124

I have run these tests locally on Linux and found everything passing except the "alt" key tests, which are skipped on Sauce and fail locally on Chrome in a way similar to what is described for Sauce.

jlipps commented 6 years ago

thanks for this and the other PRs @joeyparrish

joeyparrish commented 6 years ago

My pleasure! Thanks for taking a look.