search

admc / wd

A node.js client for webdriver/selenium 2.
Other
1.53k stars 402 forks source link

Add basic support for new W3C wire protocol #533

Closed joeyparrish closed 6 years ago

joeyparrish commented 6 years ago

This adds basic support for the new W3C wire protocol, which fixes Firefox and IE support.

For more details, see https://github.com/SeleniumHQ/selenium/issues/5952#issuecomment-392866840

This PR also includes unrelated test fixes from PR #532

Closes #495

joeyparrish commented 6 years ago

JFYI, your travis-CI config seems to be broken. It fails to connect to Sauce Labs. https://travis-ci.org/admc/wd/jobs/385401336

I have run these tests locally on Linux and found everything passing except the "alt" key tests, which are skipped on Sauce and fail locally on Chrome in a way similar to what is described for Sauce.

jlipps commented 6 years ago

also, looks like there are some conflicts to resolve

joeyparrish commented 6 years ago

Conflicts resolved, everything rebased on top of upstream master.

jlipps commented 6 years ago

cool, published as version 1.8

joeyparrish commented 6 years ago

Excellent. Thank you!